From 8f12614f2da8221438a3807b1d234517650fbdb6 Mon Sep 17 00:00:00 2001
From: Dominick Allen <djallen@librehumanitas.org>
Date: Thu, 2 Jan 2025 16:27:56 -0600
Subject: Clang tidy fixes.

---
 cmake/warnings.cmake | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

(limited to 'cmake/warnings.cmake')

diff --git a/cmake/warnings.cmake b/cmake/warnings.cmake
index 07c39b5..1787263 100644
--- a/cmake/warnings.cmake
+++ b/cmake/warnings.cmake
@@ -3,10 +3,20 @@ set(FUD_WARNINGS
     -Werror
     -Wall
     -Wextra
+
+    # gcc specific
+    # -Wstrict-null-sentinel
+    # -Wsuggest-final-types
+    # -Wsuggest-final-methods
+    # -Wimplicit-fallthrough=5
+    # -Wduplicated-branches
+    # -Wstack-usage=2048 # GCC specific
+    # -Wduplicated-cond
+    # -Wlogical-op
+
     # -pedantic
     -Wno-error=pedantic
     # -pedantic-errors
-    -Wstack-usage=2048 # GCC specific
     -Wvla # variable modified types don't play nice in C++
     # memory / data /  array / string
     -Wsizeof-pointer-memaccess
@@ -21,7 +31,6 @@ set(FUD_WARNINGS
     -Wpointer-arith
     -Wstrict-aliasing
     -Wstrict-aliasing=2
-    -Wstrict-null-sentinel
     # classes / initialization
     -Weffc++
     -Wmismatched-tags
@@ -29,8 +38,6 @@ set(FUD_WARNINGS
     -Winit-self
     -Wctor-dtor-privacy
     -Wnon-virtual-dtor
-    -Wsuggest-final-types
-    -Wsuggest-final-methods
     -Wsuggest-override
     # format
     -Wformat
@@ -50,9 +57,6 @@ set(FUD_WARNINGS
     # semantics / style
     -Wshadow
     -Wnull-dereference
-    -Wimplicit-fallthrough=5
-    -Wduplicated-branches
-    -Wduplicated-cond
     -Wcast-qual
     -Wcomment
     -Wconversion
@@ -76,7 +80,6 @@ set(FUD_WARNINGS
     -Wswitch-enum
     # this plays badly with clangd
     # -Wzero-as-null-pointer-constant
-    -Wlogical-op
     # disabled because of dragonbox
     # -Wuseless-cast
     -Wextra-semi
-- 
cgit v1.2.3