From 0b400af9519444deef4cc6ad2c43c30e2092ab4f Mon Sep 17 00:00:00 2001
From: Dominick Allen <djallen@librehumanitas.org>
Date: Sat, 4 Jan 2025 09:56:12 -0600
Subject: Fix bug related to string copying.

---
 include/fud_string_convert.hpp | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'include/fud_string_convert.hpp')

diff --git a/include/fud_string_convert.hpp b/include/fud_string_convert.hpp
index d7a62f0..e1b7e95 100644
--- a/include/fud_string_convert.hpp
+++ b/include/fud_string_convert.hpp
@@ -106,6 +106,7 @@ Result<bool, FudStatus> checkNegative(StringView& view, size_t& skipIndex);
 Result<uint8_t, FudStatus> getRadix(StringView& view, size_t& skipIndex, Option<uint8_t> specifiedRadixOption);
 
 template <typename T>
+// NOLINTNEXTLINE(performance-unnecessary-value-param)
 StringConvertResult<T> unsignedFromString(StringView nextView, size_t skipIndex, Option<uint8_t> specifiedRadixOption)
 {
     static_assert(std::is_unsigned_v<T> && std::is_integral_v<T>);
@@ -114,6 +115,7 @@ StringConvertResult<T> unsignedFromString(StringView nextView, size_t skipIndex,
         return FudError{FudStatus::ArgumentInvalid};
     }
 
+    // NOLINTNEXTLINE(performance-unnecessary-value-param)
     auto radixResult = impl::getRadix(nextView, skipIndex, specifiedRadixOption);
     if (radixResult.isError()) {
         return FudError{radixResult.takeError()};
@@ -206,6 +208,7 @@ StringConvertResult<T> signedFromString(StringView nextView, size_t skipIndex, O
         return FudError{FudStatus::ArgumentInvalid};
     }
 
+    // NOLINTNEXTLINE(performance-unnecessary-value-param)
     auto radixResult = impl::getRadix(nextView, skipIndex, specifiedRadixOption);
     if (radixResult.isError()) {
         return FudError{radixResult.takeError()};
@@ -372,6 +375,7 @@ StringConvertResult<T> floatFromString(StringView nextView, size_t skipIndex, Op
         return retSuccess();
     }
 
+    // NOLINTNEXTLINE(performance-unnecessary-value-param)
     auto radixResult = impl::getRadix(nextView, skipIndex, specifiedRadixOption);
     if (radixResult.isError()) {
         return FudError{radixResult.takeError()};
-- 
cgit v1.2.3