From 8b0bc70db73b48d833a3b5791e55921768cf6932 Mon Sep 17 00:00:00 2001 From: Dominick Allen Date: Mon, 31 Mar 2025 08:33:08 -0500 Subject: Remove reinterpret_cast usage in favor of std::bit_cast. --- test/test_string.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'test/test_string.cpp') diff --git a/test/test_string.cpp b/test/test_string.cpp index 39a24cb..f63ed71 100644 --- a/test/test_string.cpp +++ b/test/test_string.cpp @@ -39,8 +39,7 @@ TEST(FudString, BasicStringOps) ASSERT_FALSE(Ascii::valid(invalid[0])); const Array invalid2{0xFF, 0x00}; - // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast) - auto stringResult = String::makeFromCString(reinterpret_cast(invalid2.data())); + auto stringResult = String::makeFromCString(std::bit_cast(invalid2.data())); ASSERT_TRUE(stringResult.isOkay()); String fudString{stringResult.takeOkay()}; @@ -125,11 +124,9 @@ TEST(FudString, FindSubstringCxx) FudStringView stringView{}; auto findStatus = ext_string_find_substring(haystack, needle, &stringView); ASSERT_EQ(findStatus, ExtSuccess); - // NOLINTBEGIN(cppcoreguidelines-pro-type-reinterpret-cast) ASSERT_EQ( ext_string_get_c_string(&extString) + sizeof("why waste time"), - reinterpret_cast(stringView.data)); - // NOLINTEND(cppcoreguidelines-pro-type-reinterpret-cast) + std::bit_cast(stringView.data)); } TEST(TestFudString, StringBuffer) -- cgit v1.2.3