diff options
author | Dominick Allen <djallen@librehumanitas.org> | 2025-03-31 08:33:08 -0500 |
---|---|---|
committer | Dominick Allen <djallen@librehumanitas.org> | 2025-03-31 08:33:08 -0500 |
commit | 8b0bc70db73b48d833a3b5791e55921768cf6932 (patch) | |
tree | 862ae34933a7fc9f480038d974f59d7683a82605 /test/test_file.cpp | |
parent | c426110f24516f92ecb8a5374e2a281f2c79787a (diff) |
Remove reinterpret_cast usage in favor of std::bit_cast.
Diffstat (limited to 'test/test_file.cpp')
-rw-r--r-- | test/test_file.cpp | 15 |
1 files changed, 5 insertions, 10 deletions
diff --git a/test/test_file.cpp b/test/test_file.cpp index 878c740..17469e1 100644 --- a/test/test_file.cpp +++ b/test/test_file.cpp @@ -119,8 +119,7 @@ TEST(FudBufferedFile, OpenReadWrite) ASSERT_EQ(bufferedFile.file().size().getOkayOr(std::numeric_limits<size_t>::max()), 0); auto writeResult = bufferedFile.write( - // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast) - reinterpret_cast<const std::byte*>(testName.data()), + std::bit_cast<const std::byte*>(testName.data()), testName.size(), NullOpt); DrainResult expected{testName.size(), FudStatus::Success}; @@ -131,8 +130,7 @@ TEST(FudBufferedFile, OpenReadWrite) ASSERT_EQ(bufferedFile.seekStart(), FudStatus::Success); Vector<utf8> output{Vector<utf8>::withSize(testName.size()).takeOkay()}; - // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast) - auto readResult = bufferedFile.read(reinterpret_cast<std::byte*>(output.data()), testName.size(), NullOpt); + auto readResult = bufferedFile.read(std::bit_cast<std::byte*>(output.data()), testName.size(), NullOpt); ASSERT_EQ(readResult, expected); EXPECT_EQ(output.size(), testName.size()); @@ -142,22 +140,19 @@ TEST(FudBufferedFile, OpenReadWrite) ASSERT_EQ(bufferedFile.seekStart(), FudStatus::Success); expected.bytesDrained = 1; - // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast) - readResult = bufferedFile.read(reinterpret_cast<std::byte*>(output.data()), 1, NullOpt); + readResult = bufferedFile.read(std::bit_cast<std::byte*>(output.data()), 1, NullOpt); ASSERT_EQ(readResult, expected); EXPECT_EQ(output[0], testName.data()[0]); expected.bytesDrained = testName.size() - 2; - // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast) - readResult = bufferedFile.read(reinterpret_cast<std::byte*>(output.data()) + 1, testName.size() - 2, NullOpt); + readResult = bufferedFile.read(std::bit_cast<std::byte*>(output.data()) + 1, testName.size() - 2, NullOpt); ASSERT_EQ(readResult, expected); EXPECT_EQ( 0, compareMem(output.data() + 1, output.size() - 1, testName.data() + 1, testName.size() - 2).takeOkayOr(-1)); expected.bytesDrained = 1; - // NOLINTNEXTLINE(cppcoreguidelines-pro-type-reinterpret-cast) - readResult = bufferedFile.read(reinterpret_cast<std::byte*>(output.data()), 1, NullOpt); + readResult = bufferedFile.read(std::bit_cast<std::byte*>(output.data()), 1, NullOpt); EXPECT_TRUE(readResult.status == FudStatus::Success || readResult.status == FudStatus::Partial); EXPECT_EQ(output[testName.size() - 1], testName.data()[testName.size() - 1]); |